Writing great dialogue is an art. To me, it has to be up to the same standard as screen dialogue. If you cover up the dialogue and can’t tell which character is speaking then the dialogue needs rewriting.
Some good advice in this piece:
Using odd syntax & some slang is better way to convey accent than spelling out phonetically suggests Rowena Macdonald http://www.glimmertrain.com/b95macdonald.html